feat: implement duplicate ticker aggregation and mixed entry handling

Adds intelligent aggregation of duplicate ticker entries while preserving
tax lot level data internally. Implements:

- aggregate_holdings() function that groups holdings by ticker and detects
duplicate entries and mixed entry types (shares + dollars)
- Updated update_live_preview() to display aggregated positions and show
warnings for duplicates/mixed entries
- Updated fetch_and_update_preview() to aggregate holdings when calculating
portfolio values with real-time prices
- Validation warnings displayed inline in portfolio preview when:
- Duplicate tickers appear multiple times
- Mixed entry types detected (shares and dollars for same ticker)
- Added portfolio allocation percentages in price summary view

Follows industry best practice of keeping separate tax lots internally
while providing aggregated display to users, with expandable warning
section for data quality transparency.

app.py

@@ -184,6 +184,59 @@ def parse_portfolio_input(portfolio_text: str) -> List[Dict[str, Any]]:
     return holdings
 
 
+def aggregate_holdings(holdings: List[Dict[str, Any]]) -> Dict[str, Dict[str, Any]]:
+    """Aggregate holdings by ticker while preserving lot-level data.
+
+    Groups multiple entries for the same ticker together and tracks
+    individual tax lots. Useful for handling duplicate entries and
+    mixed entry types (shares + dollars).
+
+    Args:
+        holdings: List of holding dictionaries from parse_portfolio_input
+
+    Returns:
+        Dictionary with ticker as key and aggregated data as value,
+        containing: ticker, total_quantity, total_dollar_amount, lots, warnings
+    """
+    aggregated = {}
+
+    for holding in holdings:
+        ticker = holding['ticker']
+
+        if ticker not in aggregated:
+            aggregated[ticker] = {
+                'ticker': ticker,
+                'total_quantity': 0,
+                'total_dollar_amount': 0,
+                'lots': [],
+                'warnings': []
+            }
+
+        aggregated[ticker]['total_quantity'] += holding.get('quantity', 0)
+        aggregated[ticker]['total_dollar_amount'] += holding.get('dollar_amount', 0)
+        aggregated[ticker]['lots'].append(holding)
+
+    # Check for duplicates and mixed entry types
+    for ticker, data in aggregated.items():
+        if len(data['lots']) > 1:
+            has_shares = any(lot['quantity'] > 0 for lot in data['lots'])
+            has_dollars = any(lot['dollar_amount'] > 0 for lot in data['lots'])
+
+            if has_shares and has_dollars:
+                data['warnings'].append(
+                    f"{ticker} has mixed entry types (shares and dollars). "
+                    f"Total: {data['total_quantity']:.2f} sh + ${data['total_dollar_amount']:,.2f}"
+                )
+            else:
+                data['warnings'].append(
+                    f"{ticker} appears {len(data['lots'])} times. "
+                    f"Aggregated: {data['total_quantity']:.2f} shares" if has_shares
+                    else f"Aggregated: ${data['total_dollar_amount']:,.2f}"
+                )
+
+    return aggregated
+
+
 async def run_analysis(
     portfolio_text: str,
     roast_mode: bool = False,
@@ -753,6 +806,9 @@ async def run_analysis_with_ui_update(
 def update_live_preview(portfolio_text: str) -> str:
     """Update live preview with parsed portfolio summary (without prices).
 
+    Aggregates duplicate tickers and detects mixed entry types,
+    displaying warnings for data quality issues.
+
     Args:
         portfolio_text: Raw portfolio input text
 
@@ -775,31 +831,45 @@ def update_live_preview(portfolio_text: str) -> str:
             </div>
             """
 
-        holdings_count = len(holdings)
-        shares_count = sum(1 for h in holdings if h.get('quantity') and not h.get('dollar_amount'))
-        dollar_count = sum(1 for h in holdings if h.get('dollar_amount'))
+        aggregated = aggregate_holdings(holdings)
+        unique_tickers = len(aggregated)
+        shares_tickers = sum(1 for d in aggregated.values() if d['total_quantity'] > 0)
+        dollar_tickers = sum(1 for d in aggregated.values() if d['total_dollar_amount'] > 0)
+
+        warnings = []
+        for data in aggregated.values():
+            warnings.extend(data['warnings'])
+
+        warnings_html = ""
+        if warnings:
+            warnings_html = f"""
+                <div style='margin-top: 0.75rem; padding: 0.75rem; background: rgba(251, 146, 60, 0.1); border: 1px solid rgba(251, 146, 60, 0.3); border-radius: 6px;'>
+                    <p style='margin: 0 0 0.5rem 0; font-size: 11px; text-transform: uppercase; color: #fb923c; font-weight: 600;'>Duplicate/Mixed Entries</p>
+            """
+            for warning in warnings:
+                warnings_html += f"<p style='margin: 0.25rem 0 0 0; font-size: 10px; opacity: 0.9;'>{warning}</p>"
+            warnings_html += "</div>"
 
         html = f"""
         <div style='padding: 1.5rem; display: flex; flex-direction: column;'>
             <h3 style='color: #048CFC; margin-bottom: 1rem; margin-top: 0; font-size: 1.25rem;'>Portfolio Preview</h3>
             <div style='display: grid; gap: 1rem; grid-template-rows: auto 1fr auto; height: 100%;'>
                 <div style='border-bottom: 1px solid rgba(255,255,255,0.1); padding-bottom: 0.75rem;'>
-                    <p style='margin: 0; font-size: 12px; opacity: 0.7; text-transform: uppercase;'>Holdings</p>
-                    <p style='margin: 0.25rem 0 0 0; font-size: 28px; font-weight: 600;'>{holdings_count}</p>
-                    <p style='margin: 0.5rem 0 0 0; font-size: 11px; opacity: 0.6;'>{shares_count} by shares • {dollar_count} by dollar</p>
+                    <p style='margin: 0; font-size: 12px; opacity: 0.7; text-transform: uppercase;'>Unique Tickers</p>
+                    <p style='margin: 0.25rem 0 0 0; font-size: 28px; font-weight: 600;'>{unique_tickers}</p>
+                    <p style='margin: 0.5rem 0 0 0; font-size: 11px; opacity: 0.6;'>{shares_tickers} by shares • {dollar_tickers} by dollar</p>
                 </div>
                 <div style='padding-right: 0.5rem; overflow-y: auto; min-height: 0;'>
-                    <p style='margin: 0 0 0.75rem 0; font-size: 12px; opacity: 0.7; text-transform: uppercase;'>Assets</p>
+                    <p style='margin: 0 0 0.75rem 0; font-size: 12px; opacity: 0.7; text-transform: uppercase;'>Assets (Aggregated)</p>
         """
 
-        for holding in holdings:
-            ticker = holding['ticker']
-            if holding.get('dollar_amount'):
-                value_text = f"${holding['dollar_amount']:,.0f}"
-            elif holding.get('quantity'):
-                value_text = f"{holding['quantity']:.2f} sh"
+        for ticker, data in sorted(aggregated.items()):
+            if data['total_dollar_amount'] > 0 and data['total_quantity'] > 0:
+                value_text = f"{data['total_quantity']:.2f} sh + ${data['total_dollar_amount']:,.0f}"
+            elif data['total_dollar_amount'] > 0:
+                value_text = f"${data['total_dollar_amount']:,.0f}"
             else:
-                value_text = "—"
+                value_text = f"{data['total_quantity']:.2f} sh"
 
             html += f"""
                     <div style='display: flex; justify-content: space-between; padding: 0.65rem 0; border-bottom: 1px solid rgba(255,255,255,0.05);'>
@@ -808,11 +878,12 @@ def update_live_preview(portfolio_text: str) -> str:
                     </div>
             """
 
-        html += """
+        html += f"""
                 </div>
                 <div style='margin-top: 0.5rem; padding: 0.75rem; background: rgba(4, 140, 252, 0.1); border-radius: 6px; text-align: center;'>
                     <p style='margin: 0; font-size: 11px; opacity: 0.8;'>Click "Get Current Prices" for live valuation</p>
                 </div>
+                {warnings_html}
             </div>
         </div>
         """
@@ -825,6 +896,9 @@ def update_live_preview(portfolio_text: str) -> str:
 async def fetch_and_update_preview(portfolio_text: str) -> str:
     """Fetch current prices and update preview with calculated values.
 
+    Aggregates duplicate tickers and displays combined positions
+    with pricing information from market data sources.
+
     Args:
         portfolio_text: Raw portfolio input text
 
@@ -839,8 +913,13 @@ async def fetch_and_update_preview(portfolio_text: str) -> str:
         if not holdings:
             return update_live_preview(portfolio_text)
 
+        aggregated = aggregate_holdings(holdings)
+
         # Get tickers that need price lookup (have quantity but no dollar_amount)
-        tickers_needing_prices = [h['ticker'] for h in holdings if h.get('quantity') and not h.get('dollar_amount')]
+        tickers_needing_prices = [
+            ticker for ticker, data in aggregated.items()
+            if data['total_quantity'] > 0 and data['total_dollar_amount'] == 0
+        ]
 
         # Fetch current prices
         prices = {}
@@ -859,48 +938,66 @@ async def fetch_and_update_preview(portfolio_text: str) -> str:
             except Exception as e:
                 logger.error(f"Error fetching prices: {e}")
 
-        # Calculate values
+        # Calculate aggregated values
         total_value = 0
-        for holding in holdings:
-            if holding.get('dollar_amount'):
-                holding['current_value'] = holding['dollar_amount']
-                total_value += holding['dollar_amount']
-            elif holding.get('quantity'):
-                price = prices.get(holding['ticker'], 0)
-                holding['current_value'] = holding['quantity'] * price
-                total_value += holding['current_value']
-
-        # Generate HTML with prices
-        holdings_count = len(holdings)
+        aggregated_values = {}
+
+        for ticker, data in aggregated.items():
+            if data['total_dollar_amount'] > 0:
+                aggregated_values[ticker] = data['total_dollar_amount']
+                total_value += data['total_dollar_amount']
+            elif data['total_quantity'] > 0:
+                price = prices.get(ticker, 0)
+                value = data['total_quantity'] * price
+                aggregated_values[ticker] = value
+                total_value += value
+
+        unique_tickers = len(aggregated)
+        warnings = []
+        for data in aggregated.values():
+            warnings.extend(data['warnings'])
+
+        warnings_html = ""
+        if warnings:
+            warnings_html = f"""
+                <div style='margin-top: 0.75rem; padding: 0.75rem; background: rgba(251, 146, 60, 0.1); border: 1px solid rgba(251, 146, 60, 0.3); border-radius: 6px;'>
+                    <p style='margin: 0 0 0.5rem 0; font-size: 11px; text-transform: uppercase; color: #fb923c; font-weight: 600;'>Duplicate/Mixed Entries</p>
+            """
+            for warning in warnings:
+                warnings_html += f"<p style='margin: 0.25rem 0 0 0; font-size: 10px; opacity: 0.9;'>{warning}</p>"
+            warnings_html += "</div>"
 
         html = f"""
         <div style='padding: 1.5rem; display: flex; flex-direction: column;'>
             <h3 style='color: #048CFC; margin-bottom: 1rem; margin-top: 0; font-size: 1.25rem;'>Portfolio Summary</h3>
             <div style='display: grid; gap: 1rem; grid-template-rows: auto auto 1fr auto; height: 100%;'>
                 <div style='border-bottom: 1px solid rgba(255,255,255,0.1); padding-bottom: 0.75rem;'>
-                    <p style='margin: 0; font-size: 12px; opacity: 0.7; text-transform: uppercase;'>Holdings</p>
-                    <p style='margin: 0.25rem 0 0 0; font-size: 28px; font-weight: 600;'>{holdings_count}</p>
+                    <p style='margin: 0; font-size: 12px; opacity: 0.7; text-transform: uppercase;'>Unique Tickers</p>
+                    <p style='margin: 0.25rem 0 0 0; font-size: 28px; font-weight: 600;'>{unique_tickers}</p>
                 </div>
                 <div style='border-bottom: 1px solid rgba(255,255,255,0.1); padding-bottom: 0.75rem;'>
                     <p style='margin: 0; font-size: 12px; opacity: 0.7; text-transform: uppercase;'>Total Value</p>
                     <p style='margin: 0.25rem 0 0 0; font-size: 24px; font-weight: 600; color: #10b981;'>${total_value:,.2f}</p>
                 </div>
                 <div style='padding-right: 0.5rem; overflow-y: auto; min-height: 0;'>
-                    <p style='margin: 0 0 0.75rem 0; font-size: 12px; opacity: 0.7; text-transform: uppercase;'>Holdings Breakdown</p>
+                    <p style='margin: 0 0 0.75rem 0; font-size: 12px; opacity: 0.7; text-transform: uppercase;'>Holdings Breakdown (Aggregated)</p>
         """
 
-        for holding in holdings:
-            ticker = holding['ticker']
-            current_value = holding.get('current_value', 0)
+        for ticker in sorted(aggregated.keys()):
+            data = aggregated[ticker]
+            current_value = aggregated_values.get(ticker, 0)
+            weight = (current_value / total_value * 100) if total_value > 0 else 0
 
-            if holding.get('dollar_amount'):
-                detail = f"${holding['dollar_amount']:,.2f}"
-            elif holding.get('quantity'):
+            if data['total_dollar_amount'] > 0 and data['total_quantity'] > 0:
+                detail = f"{data['total_quantity']:.2f} sh + ${data['total_dollar_amount']:,.2f}"
+            elif data['total_dollar_amount'] > 0:
+                detail = f"${data['total_dollar_amount']:,.2f}"
+            elif data['total_quantity'] > 0:
                 price = prices.get(ticker, 0)
                 if price > 0:
-                    detail = f"{holding['quantity']:.2f} sh × ${price:.2f}"
+                    detail = f"{data['total_quantity']:.2f} sh × ${price:.2f}"
                 else:
-                    detail = f"{holding['quantity']:.2f} sh (price unavailable)"
+                    detail = f"{data['total_quantity']:.2f} sh (price unavailable)"
             else:
                 detail = "—"
 
@@ -910,15 +1007,19 @@ async def fetch_and_update_preview(portfolio_text: str) -> str:
                             <div style='font-weight: 500; font-size: 0.95rem;'>{ticker}</div>
                             <div style='font-size: 11px; opacity: 0.6; margin-top: 2px;'>{detail}</div>
                         </div>
-                        <span style='font-weight: 600; color: #10b981; font-size: 0.95rem;'>${current_value:,.2f}</span>
+                        <div style='text-align: right;'>
+                            <div style='font-weight: 600; color: #10b981; font-size: 0.95rem;'>${current_value:,.2f}</div>
+                            <div style='font-size: 11px; opacity: 0.6; margin-top: 2px;'>{weight:.1f}%</div>
+                        </div>
                     </div>
             """
 
-        html += """
+        html += f"""
                 </div>
                 <div style='margin-top: 0.5rem; padding: 0.75rem; background: rgba(16, 185, 129, 0.1); border-radius: 6px; text-align: center;'>
-                    <p style='margin: 0; font-size: 11px; color: #10b981;'>✓ Prices updated</p>
+                    <p style='margin: 0; font-size: 11px; color: #10b981;'>Prices updated</p>
                 </div>
+                {warnings_html}
             </div>
         </div>
         """
@@ -1085,13 +1186,14 @@ def create_interface() -> gr.Blocks:
         border: 1px solid rgba(255, 255, 255, 0.2);
         border-radius: 12px;
         padding: 0;
-        flex: 0 0 auto !important;
+        flex: 1 1 auto !important;
         max-height: 800px !important;
         min-height: 0;
         overflow-y: auto;
         overflow-x: hidden;
         display: flex !important;
         flex-direction: column !important;
+        box-sizing: border-box !important;
     }
 
     /* Custom scrollbar for preview card */
@@ -1158,6 +1260,9 @@ def create_interface() -> gr.Blocks:
         flex: 1 1 0% !important;
         height: 100% !important;
         min-height: 100% !important;
+        max-height: 100% !important;
+        gap: 0 !important;
+        overflow: hidden !important;
     }
 
     .portfolio-row > * {
@@ -1172,9 +1277,10 @@ def create_interface() -> gr.Blocks:
 
     /* Button fixed sizing - prevent vertical expansion */
     .portfolio-row button {
-        flex: 0 0 auto !important;
-        align-self: stretch !important;
+        flex: 0 0 45px !important;
         width: 100% !important;
+        height: 45px !important;
+        min-height: 45px !important;
         max-height: 45px !important;
     }