fix: resolve audio integration issues and improve UI layout

Fix multiple issues preventing audio features from working correctly:

Backend fixes:
- Remove incorrect await on ElevenLabs async generator in TTSService
- Remove incorrect await in DebateAudioGenerator._generate_segment
- Fix async generator pattern (use async for without await on generator call)

Frontend fixes:
- Fix handle_analysis to return and handle audio button in all yields
- Fix handle_build_portfolio to include audio button in all 4 yield statements
- Fix handle_compare_portfolio to include audio button in all 5 yield statements
- Handle both list and dict formats for portfolio_data in build result storage
- Add os import for file existence checks
- Wrap all audio players in Row containers for proper layout spacing
- Add debug logging to generate_debate_audio for troubleshooting

All three audio features (Analyse Portfolio, Build Portfolio, Compare Strategies) now work correctly with visible audio players.

app.py

@@ -11,6 +11,7 @@ Features:
 
 import gradio as gr
 import asyncio
+import os
 import re
 import logging
 import warnings
@@ -979,7 +980,8 @@ async def run_analysis_with_ui_update(
             "input",
             f"❌ Error: {str(e)}",
             "",
-            None, None, None, None, None
+            None, None, None, None, None,
+            gr.update(visible=False)  # analysis_audio_btn (hide on error)
         )
 
 
@@ -2077,12 +2079,13 @@ def create_interface() -> gr.Blocks:
                                 size="sm",
                                 visible=False
                             )
-                        build_audio_player = gr.Audio(
-                            label="Portfolio Summary Audio",
-                            interactive=False,
-                            visible=False,
-                            show_download_button=True
-                        )
+                        with gr.Row():
+                            build_audio_player = gr.Audio(
+                                label="Portfolio Summary Audio",
+                                interactive=False,
+                                visible=False,
+                                show_download_button=True
+                            )
 
                         with gr.Row():
                             build_regenerate_btn = gr.Button("Regenerate", variant="secondary", size="sm")
@@ -2155,12 +2158,13 @@ def create_interface() -> gr.Blocks:
                                 size="sm",
                                 visible=False
                             )
-                        compare_audio_player = gr.Audio(
-                            label="Advisory Council Debate Audio",
-                            interactive=False,
-                            visible=False,
-                            show_download_button=True
-                        )
+                        with gr.Row():
+                            compare_audio_player = gr.Audio(
+                                label="Advisory Council Debate Audio",
+                                interactive=False,
+                                visible=False,
+                                show_download_button=True
+                            )
 
                         # Debate transcript
                         with gr.Accordion("View Full Debate", open=False):
@@ -2475,12 +2479,13 @@ def create_interface() -> gr.Blocks:
                                 size="sm",
                                 visible=False
                             )
-                        analysis_audio_player = gr.Audio(
-                            label="Audio Summary",
-                            interactive=False,
-                            visible=False,
-                            show_download_button=True
-                        )
+                        with gr.Row():
+                            analysis_audio_player = gr.Audio(
+                                label="Audio Summary",
+                                interactive=False,
+                                visible=False,
+                                show_download_button=True
+                            )
 
                         # Performance Metrics Accordion (progressive disclosure)
                         with gr.Accordion("Performance Metrics & Reasoning", open=False):
@@ -2901,6 +2906,13 @@ def create_interface() -> gr.Blocks:
             """Generate multi-speaker debate audio on-demand."""
             global LAST_DEBATE_DATA
 
+            logger.info(f"generate_debate_audio called. LAST_DEBATE_DATA exists: {LAST_DEBATE_DATA is not None}")
+            if LAST_DEBATE_DATA:
+                logger.info(f"Debate data keys: {LAST_DEBATE_DATA.keys()}")
+                logger.info(f"Bull case length: {len(LAST_DEBATE_DATA.get('bull_case', ''))}")
+                logger.info(f"Bear case length: {len(LAST_DEBATE_DATA.get('bear_case', ''))}")
+                logger.info(f"Consensus length: {len(LAST_DEBATE_DATA.get('consensus', ''))}")
+
             if not LAST_DEBATE_DATA:
                 logger.warning("No debate data available for audio generation")
                 return (
@@ -2947,6 +2959,8 @@ def create_interface() -> gr.Blocks:
                 )
 
                 logger.info(f"Debate audio generated: {audio_path}")
+                logger.info(f"Audio file exists: {os.path.exists(audio_path) if audio_path else False}")
+                logger.info(f"Returning audio player update with visible=True")
 
                 return (
                     gr.update(value=audio_path, visible=True),
@@ -2982,7 +2996,8 @@ def create_interface() -> gr.Blocks:
                 yield (
                     gr.update(value=[], visible=False),  # build_agent_chat (empty, hidden)
                     gr.update(visible=True),  # build_results_container
-                    "Please select at least one investment goal."  # build_status
+                    "Please select at least one investment goal.",  # build_status
+                    gr.update(visible=False)  # build_audio_btn (hide on error)
                 )
                 return
 
@@ -3029,7 +3044,8 @@ def create_interface() -> gr.Blocks:
                             yield (
                                 gr.update(value=chat_messages, visible=True),  # build_agent_chat (visible, growing list)
                                 gr.update(visible=False),  # build_results_container (hidden during streaming)
-                                ""  # build_status
+                                "",  # build_status
+                                gr.update(visible=False)  # build_audio_btn (hide during streaming)
                             )
                             logger.debug(f"UI update yielded successfully")
                         except Exception as e:
@@ -3052,9 +3068,17 @@ def create_interface() -> gr.Blocks:
                     final_message = chat_messages[-1]
                     if isinstance(final_message, dict) and "metadata" in final_message:
                         portfolio_data = final_message.get("metadata", {}).get("portfolio", {})
+                        # Handle both dict and list formats
+                        if isinstance(portfolio_data, list):
+                            holdings = portfolio_data
+                        elif isinstance(portfolio_data, dict):
+                            holdings = portfolio_data.get("holdings", [])
+                        else:
+                            holdings = []
+
                         LAST_BUILD_RESULT = {
                             "summary": final_message.get("content", ""),
-                            "holdings": portfolio_data.get("holdings", []),
+                            "holdings": holdings,
                             "reasoning": final_message.get("metadata", {}).get("reasoning_trace", [])
                         }
                         logger.info("Build result stored for audio generation")
@@ -3092,7 +3116,8 @@ def create_interface() -> gr.Blocks:
                 yield (
                     gr.update(value=[], visible=False),  # build_agent_chat (empty, hidden on error)
                     gr.update(visible=True),  # build_results_container
-                    f"Error building portfolio: {str(e)}"  # build_status
+                    f"Error building portfolio: {str(e)}",  # build_status
+                    gr.update(visible=False)  # build_audio_btn (hide on error)
                 )
 
         def handle_build_accept(portfolio_table):
@@ -3160,7 +3185,8 @@ def create_interface() -> gr.Blocks:
                     0,  # compare_bear_confidence
                     "",  # compare_consensus
                     "",  # compare_stance
-                    []  # compare_debate_transcript
+                    [],  # compare_debate_transcript
+                    gr.update(visible=False)  # compare_audio_btn (hide on error)
                 )
                 return
 
@@ -3172,7 +3198,8 @@ def create_interface() -> gr.Blocks:
                     gr.update(value=[], visible=False),  # compare_debate_chat (empty, hidden)
                     gr.update(visible=True),  # compare_results_container
                     "Could not parse portfolio. Please check format.",  # compare_status
-                    "", 0, "", 0, "", "", []
+                    "", 0, "", 0, "", "", [],
+                    gr.update(visible=False)  # compare_audio_btn (hide on error)
                 )
                 return
 
@@ -3205,7 +3232,8 @@ def create_interface() -> gr.Blocks:
                         0,  # compare_bear_confidence
                         "",  # compare_consensus
                         "",  # compare_stance
-                        []  # compare_debate_transcript
+                        [],  # compare_debate_transcript
+                        gr.update(visible=False)  # compare_audio_btn (hide during streaming)
                     )
 
                     # Extract data from final consensus message
@@ -3264,7 +3292,8 @@ def create_interface() -> gr.Blocks:
                     gr.update(value=[], visible=False),  # compare_debate_chat (empty, hidden on error)
                     gr.update(visible=True),  # compare_results_container
                     f"Error: {str(e)}",  # compare_status
-                    "", 0, "", 0, "", "", []
+                    "", 0, "", 0, "", "", [],
+                    gr.update(visible=False)  # compare_audio_btn (hide on error)
                 )
 
         async def handle_test_changes(portfolio_text, changes_text, portfolio_value, session_state):
@@ -4068,7 +4097,7 @@ Please try again with different parameters.
             }
 
             # Run analysis with progress updates
-            page, analysis, perf_metrics, alloc, risk, perf, corr, opt = await run_analysis_with_ui_update(
+            page, analysis, perf_metrics, alloc, risk, perf, corr, opt, audio_btn = await run_analysis_with_ui_update(
                 session_state, portfolio_text, roast_mode, persona, progress
             )
 
@@ -4087,6 +4116,7 @@ Please try again with different parameters.
                     performance_plot: perf,
                     correlation_plot: corr,
                     optimization_plot: opt,
+                    analysis_audio_btn: audio_btn,
                     load_past_portfolio_dropdown: gr.update(choices=dropdown_choices) if dropdown_choices else gr.skip(),
                     export_pdf_btn: LAST_EXPORT_PDF_PATH,
                     export_csv_btn: LAST_EXPORT_CSV_PATH
@@ -4104,6 +4134,7 @@ Please try again with different parameters.
                     performance_plot: None,
                     correlation_plot: None,
                     optimization_plot: None,
+                    analysis_audio_btn: audio_btn,
                     load_past_portfolio_dropdown: gr.skip(),
                     export_pdf_btn: gr.skip(),
                     export_csv_btn: gr.skip()

backend/audio/tts_service.py

@@ -63,7 +63,7 @@ class TTSService:
         logger.info(f"Generating audio: {len(text)} characters")
 
         try:
-            audio_generator = await self.client.text_to_speech.convert(
+            audio_generator = self.client.text_to_speech.convert(
                 text=text,
                 voice_id=voice_id or self.default_voice_id,
                 model_id=model,
@@ -277,7 +277,7 @@ class DebateAudioGenerator:
         Returns:
             Audio data as bytes
         """
-        audio_generator = await self.client.text_to_speech.convert(
+        audio_generator = self.client.text_to_speech.convert(
             text=text,
             voice_id=voice_id,
             model_id="eleven_multilingual_v2",